To: vim_dev@googlegroups.com Subject: Patch 8.1.2253 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.1.2253 Problem: Using "which" to check for an executable is not reliable. Solution: Use "command -v" instead. Also exit with error code when generating tags has an error. (closes #5174) Files: runtime/doc/Makefile *** ../vim-8.1.2252/runtime/doc/Makefile 2019-11-03 21:46:16.425213135 +0100 --- runtime/doc/Makefile 2019-11-04 21:22:35.145308509 +0100 *************** *** 323,331 **** # Use Vim to generate the tags file. Can only be used when Vim has been # compiled and installed. Supports multiple languages. vimtags: $(DOCS) ! @if which $(VIMEXE) >/dev/null; then \ ! $(VIMEXE) --clean -eX -u doctags.vim >/dev/null; \ ! echo "help tags updated"; \ else echo "vim executable $(VIMEXE) not found; help tags not updated"; fi # Use "doctags" to generate the tags file. Only works for English! --- 323,331 ---- # Use Vim to generate the tags file. Can only be used when Vim has been # compiled and installed. Supports multiple languages. vimtags: $(DOCS) ! @if command -v $(VIMEXE); then \ ! $(VIMEXE) --clean -eX -u doctags.vim >/dev/null && \ ! echo "help tags updated"; \ else echo "vim executable $(VIMEXE) not found; help tags not updated"; fi # Use "doctags" to generate the tags file. Only works for English! *** ../vim-8.1.2252/src/version.c 2019-11-04 20:36:46.128633933 +0100 --- src/version.c 2019-11-04 21:24:30.808840203 +0100 *************** *** 743,744 **** --- 743,746 ---- { /* Add new patch number below this line */ + /**/ + 2253, /**/ -- The technology involved in making anything invisible is so infinitely complex that nine hundred and ninety-nine billion, nine hundred and ninety-nine million, nine hundred and ninety-nine thousand, nine hundred and ninety-nine times out of a trillion it is much simpler and more effective just to take the thing away and do without it. -- Douglas Adams, "The Hitchhiker's Guide to the Galaxy" /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///