To: vim_dev@googlegroups.com Subject: Patch 8.2.0435 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.0435 Problem: Channel contents might be freed twice. Solution: Call either channel_free_channel() or channel_free(), not both. (Nobuhiro Takasaki, closes #5835) Files: src/channel.c *** ../vim-8.2.0434/src/channel.c 2020-01-30 16:27:02.068562909 +0100 --- src/channel.c 2020-03-23 21:57:55.538277643 +0100 *************** *** 4457,4465 **** if (channel->ch_killing) { channel_free_contents(channel); channel->ch_job->jv_channel = NULL; } ! channel_free(channel); // channel has been freed, start over channel = first_channel; continue; --- 4457,4467 ---- if (channel->ch_killing) { channel_free_contents(channel); + channel_free_channel(channel); channel->ch_job->jv_channel = NULL; } ! else ! channel_free(channel); // channel has been freed, start over channel = first_channel; continue; *** ../vim-8.2.0434/src/version.c 2020-03-23 21:45:25.719928947 +0100 --- src/version.c 2020-03-23 21:59:53.369429945 +0100 *************** *** 740,741 **** --- 740,743 ---- { /* Add new patch number below this line */ + /**/ + 435, /**/ -- ARTHUR: Well, it doesn't matter. Will you go and tell your master that Arthur from the Court of Camelot is here. GUARD #1: Listen, in order to maintain air-speed velocity, a swallow needs to beat its wings 43 times every second, right? ARTHUR: Please! The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///