To: vim_dev@googlegroups.com
Subject: Patch 8.2.3481
Fcc: outbox
From: Bram Moolenaar <Bram@moolenaar.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
------------

Patch 8.2.3481
Problem:    Failures when char is unsigned.
Solution:   Use int8_T.  Make a CI run with unsigned char. (James McCoy,
            closes #8936)
Files:      src/structs.h, .github/workflows/ci.yml


*** ../vim-8.2.3480/src/structs.h	2021-10-05 11:22:21.553842709 +0100
--- src/structs.h	2021-10-05 19:36:48.924434161 +0100
***************
*** 1406,1413 ****
  struct type_S {
      vartype_T	    tt_type;
      int8_T	    tt_argcount;    // for func, incl. vararg, -1 for unknown
!     char	    tt_min_argcount; // number of non-optional arguments
!     char	    tt_flags;	    // TTFLAG_ values
      type_T	    *tt_member;	    // for list, dict, func return type
      type_T	    **tt_args;	    // func argument types, allocated
  };
--- 1406,1413 ----
  struct type_S {
      vartype_T	    tt_type;
      int8_T	    tt_argcount;    // for func, incl. vararg, -1 for unknown
!     int8_T	    tt_min_argcount; // number of non-optional arguments
!     char_u	    tt_flags;	    // TTFLAG_ values
      type_T	    *tt_member;	    // for list, dict, func return type
      type_T	    **tt_args;	    // func argument types, allocated
  };
*** ../vim-8.2.3480/.github/workflows/ci.yml	2021-09-19 16:54:39.364199315 +0100
--- .github/workflows/ci.yml	2021-10-05 19:39:43.395517977 +0100
***************
*** 40,45 ****
--- 40,46 ----
              compiler: gcc
              coverage: true
              extra: testgui
+             uchar: true
            - features: huge
              compiler: clang
              extra: asan
***************
*** 111,120 ****
              ;;
            esac
  
            if ${{ matrix.coverage == true }}; then
!             echo "CFLAGS=--coverage -DUSE_GCOV_FLUSH"
              echo "LDFLAGS=--coverage"
            fi
            if ${{ contains(matrix.extra, 'testgui') }}; then
              echo "TEST=-C src testgui"
            fi
--- 112,125 ----
              ;;
            esac
  
+           CFLAGS=""
            if ${{ matrix.coverage == true }}; then
!             CFLAGS="$CFLAGS --coverage -DUSE_GCOV_FLUSH"
              echo "LDFLAGS=--coverage"
            fi
+           if ${{ matrix.uchar == true }}; then
+             CFLAGS="$CFLAGS -funsigned-char"
+           fi
            if ${{ contains(matrix.extra, 'testgui') }}; then
              echo "TEST=-C src testgui"
            fi
***************
*** 130,135 ****
--- 135,141 ----
            if ${{ contains(matrix.extra, 'vimtags') }}; then
              echo "TEST=-C runtime/doc vimtags VIMEXE=../../${SRCDIR}/vim"
            fi
+           echo "CFLAGS=$CFLAGS"
            ) >> $GITHUB_ENV
  
        - name: Set up system
*** ../vim-8.2.3480/src/version.c	2021-10-05 19:27:58.078919775 +0100
--- src/version.c	2021-10-05 19:43:47.355580687 +0100
***************
*** 759,760 ****
--- 759,762 ----
  {   /* Add new patch number below this line */
+ /**/
+     3481,
  /**/

-- 
hundred-and-one symptoms of being an internet addict:
105. When someone asks you for your address, you tell them your URL.

 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
///                                                                      \\\
\\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///